Fix #20478: Remove output.globalObject from webpack config#20481
Open
jagadish-555 wants to merge 2 commits intomozilla:masterfrom
Open
Fix #20478: Remove output.globalObject from webpack config#20481jagadish-555 wants to merge 2 commits intomozilla:masterfrom
jagadish-555 wants to merge 2 commits intomozilla:masterfrom
Conversation
Contributor
Could you give some pointers about that ? |
Author
ESM builds do not use the global object at all. They rely purely on import/export. |
Removed unnecessary blank lines in the configuration.
|
I'm experiencing the same issue. Any updates on this PR? |
Contributor
|
This setting still affects the global property, even in an ESM build, so removing it it's a breaking change. It should be eventually done though. On a side note, Next.js should be fixed to not crash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a compatibility issue with Next.js 16 where importing
pdfjs-distcauses anObject.definePropertyerror.The issue arises because the combination of
outputModule: trueandoutput.globalObject: "globalThis"in the Webpack configuration generates code that is incompatible with the Webpack runtime used by Next.js (specifically when usingeval-based source maps).Changes
output.globalObject = "globalThis"from gulpfile.mjsThis setting is unnecessary for ES Module builds (
library.type: "module") and removing it resolves the conflict, allowingpdfjs-distto be imported correctly in Next.js environments.Fixes #20478