Make the caret visible in the text layer in caret browsing mode#17533
Make the caret visible in the text layer in caret browsing mode#17533calixteman merged 1 commit intomozilla:masterfrom
Conversation
calixteman
force-pushed
the
caret_mode
branch
from
f02ec75 to
62c25ea
Compare
|
Here's a screenshot of the results of search in HCM (night sky) |
In order to do that we must change the text layer opacity to 1 but it has several implications: - the selection color must have an alpha component, - the background color of the span used for highlighted words must have an alpha component either, but now the opacity is 1 we can use some backdrop-filters in HCM making the highlighted words more visible. - fix a regression caused by mozilla#17196: the css variable --hcm-highlight-filter has to live under the #viewer element because in HCM it's overwritten by js at this level, hence links annotations for example didn't have the right colors when hovered.
calixteman
force-pushed
the
caret_mode
branch
from
62c25ea to
83c78db
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a8da041f4acd38d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a8da041f4acd38d/output.txt Total script time: 1.59 mins Published |
Snuffleupagus
left a comment
Snuffleupagus
left a comment
There was a problem hiding this comment.
r=me, with passing tests; thank you!
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d4b89667aa49aa2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5f46d086b4d0e1a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d4b89667aa49aa2/output.txt Total script time: 24.54 mins
Image differences available at: http://54.241.84.105:8877/d4b89667aa49aa2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5f46d086b4d0e1a/output.txt Total script time: 40.21 mins
Image differences available at: http://54.193.163.58:8877/5f46d086b4d0e1a/reftest-analyzer.html#web=eq.log |
3 participants
In order to do that we must change the text layer opacity to 1 but it has several implications: