Repository navigation
electron and web workers #6932
Description
Activity
We cannot introduce
typeof window === 'undefined'-- the stubs for window object can be added to global. Can we rely on something else, e.g. process?I think it should be ok, I'll check it tomorrow. I was thinking about __filename too, but it doesn't exists in node repl, just when evaluated in a script.
ok I think this might do:
node
~ node > process.versions.electron undefinedelectron
process.versions.electron "0.36.5"I'll do some tests with this code:
if (typeof module !== 'undefined' && module.require && typeof process.versions.electron === 'undefined') {
What about ditching duck-typing of the environment and using
typeof Worker !== 'function'instead?Reacted by njlrI think that should be ok too
Fixed our dependence on stub for worker, so
typeof worker === 'undefined'check shall work now. See #7126 and it shall fix this issue.thanks, we'll try it soon!
Hi, we are developing an app which runs in the browser and as an electron app. There's been a release that has introduced this code:
The problem is that
module.requireexists in electron too, so web workers are disabled even if they should not. I patched pdf.js this way:and it seems to work. I think this patch should not cause other unwanted troubles, so could it be possibile to add it to pdf.js?