Refactor PDFJS global var usage and move it initialization into single file

for v1.x we are going to keep supporting accessing PDFJS.xxxx members, however for future (e.g. v2.0) we shall probably rely only on module exports keeping that single file as compatibility feature.

TODO:

move all preferences from api.js into parameter object for related methods (e.g. disableRange is parameter for getDocument, and externalLinkTarget for AnnotationLayer.render)
refactor global PDFJS usage/assignments from all core/, shared/ and display/ , keep them in the single file e.g. src/display/globals.js

@yurydelendik

Is this issue still up @yurydelendik ?

Though I guess either of the tasks have been achieved in the respective PRs

You're right, both tasks should be done already when the last pull request above is merged.

@timvandermeij

Thanks @timvandermeij for confirming. I'll look up for something else 👍

Closing, since the remaining TODO was fixed by PR #9493.

Navigation Menu

Repository navigation

Refactor PDFJS global var usage and move it initialization into single file #6779

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Refactor PDFJS global var usage and move it initialization into single file #6779

Description

Activity

shikhar-scs commented on Jan 20, 2018

timvandermeij commented on Jan 20, 2018

shikhar-scs commented on Jan 20, 2018

Snuffleupagus commented on Mar 4, 2018

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions