This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
Pytest selenium 1.2.0 #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I discovered this today with bedrock. The issue is pytest-dev/pytest#1062 which is fixed in the upcoming pytest 2.9. I'm happy with pinning pytest to 2.7.3 for now or pinning pytest-selenium to 1.1. I guess it's a good thing we're not on 2.8 elsewhere. 😄 |
| pytest==2.8.5 | ||
| pytest-selenium | ||
| pytest==2.7.3 | ||
| pytest-selenium>=1.2.0rc1 |
There was a problem hiding this comment.
No need for the >=1.2.0rc1 now as 1.2.1 is released and will be picked up.
|
r+ wc |
|
Replaced by #330 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @bobsilverberg @davehunt - I've done an ad-hoc job, which passes: http://webqa-ci-staging1.qa.scl3.mozilla.com:8080/job/oneanddone.adhoc/66/console
I'm not confident nor happy about downgrading pytest, just to get this to pass (see http://webqa-ci-staging1.qa.scl3.mozilla.com:8080/job/oneanddone.adhoc/65/ for failures with pytest 2.8.5).
I'm really out of my realm here, sorry; still getting up-to-speed, and thought this would be easy!
Feel free to take over completely, as well!