chore: replace fs-extra with native Node.js fs in tests - #1524
Open
roli-lpci wants to merge 1 commit into
Open
Conversation
fs-extra was only used in tests/core.js for emptyDirSync, which can
be replaced with fs.rmSync({ recursive: true, force: true }). All
other methods used (mkdtempSync, writeFileSync, rmdirSync) are already
native fs methods.
This removes fs-extra and its 3 transitive dependencies (graceful-fs,
jsonfile, universalify) from devDependencies.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs-extrawith nativefsmodule intests/core.jsfs-extrawas only used foremptyDirSync— replaced withfs.rmSync({ recursive: true, force: true })mkdtempSync,writeFileSync) are already nativefsmethodsfs-extraand its 3 transitive dependencies (graceful-fs,jsonfile,universalify) from devDependenciesChanges
tests/core.js—require('fs-extra')→require('fs'),emptyDirSync/rmdirSync→rmSyncpackage.json— removedfs-extrafrom devDependenciespackage-lock.json— regeneratedTesting
All 246 tests pass, 0 failures. Lint clean.