Fix engine dependency version for Node versions > 11.1.0 #1169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed change:
Fix engine dependency version for Node versions > 11.1.0;
now there is only a minimum Node dependency and not a maximum dependency;
the engine dependency is now a blacklist rather than a whitelist;
it indicates Node versions that are known NOT to work, and unknown future
versions are accepted by default rather than rejected by default.
This fixes a systematic problem where Nunjucks and all of its downstream
dependencies break every time a new Node version is released, despite the
Node update being backwards compatible, thus forcing a new Nunjucks
release such as 3.1.4 until the goalpost is soon moved again.
Closes #1168 .
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.