Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cache ttl for self-repair #1563

Closed
sciurus opened this issue Sep 28, 2018 · 4 comments
Closed

Increase cache ttl for self-repair #1563

sciurus opened this issue Sep 28, 2018 · 4 comments

Comments

@sciurus
Copy link
Contributor

sciurus commented Sep 28, 2018

No description provided.

@mythmon
Copy link
Contributor

mythmon commented Oct 1, 2018

"self-repair" here refers to https://normandy.cdn.mozilla.net/en-US/repair/. This was the page that the predecessor of Normandy used. It was loaded in a background iframe and given some special privileges. Normandy used it as a shim while the system add-on was in development. We keep it around for very old Firefoxes that might still hit, but it is now simply a message explaining its own deprecation.

The current cache TTL is 30 seconds. Given that it isn't expect to change, but doesn't have a hashed URL, I suggest we give it a one day TTL.

It may also make sense to simply remove this URL entirely, but I'd like to hear more about how many hits we are still getting to it. We have theorized needing to re-activate this URL for some special circumstance where we needed to contact the Firefox clients still hitting it, and could do something with the limited capabilities the old system had. I think that time has probably passed now.

@sciurus
Copy link
Contributor Author

sciurus commented Oct 1, 2018

self-repair is the only traffic to the elb named shield; you can see its traffic here. It gets about 40 million hits a day. The most prominent user-agents in the logs are variations on Firefox/52.0.

@mythmon
Copy link
Contributor

mythmon commented Oct 1, 2018

Ah, ok. Thanks for chekcing. ESR 52 didn't get the system add-on version of Normandy (even though Release 52 did). We'll have to keep supporting that for a while. Notably, ESR 52 is where we put all the Windows XP users, and was the last ESR release before Firefox 57 when we broke all the legacy extensions. It's going to be with us for a while. Lets bump the cache time so at least we don't have to spend as much supporting them. Maybe a week would be a better TTL, what do you think?

@sciurus
Copy link
Contributor Author

sciurus commented Oct 2, 2018

Either sounds fine. There's no real harm in going longer, since in the off chance that we have to change the content we can invalidate the cached items.

mythmon added a commit to mythmon/normandy that referenced this issue Oct 4, 2018
This view serves a message that the system is no longer active. We keep it aroud
because it is still gets about 40 million hits per day, primarily from Firefox
ESR 52, which never got the Normandy client. Notably, when we dropped support
for Windows XP from Firefox, we put all XP users onto ESR 52, so we are not
likely to be able to remove this endpoint any time soon.

Fixes mozilla#1563
mythmon added a commit to mythmon/normandy that referenced this issue Oct 4, 2018
This view serves a message that the system is no longer active. We keep
it around because it is still gets about 40 million hits per day,
primarily from Firefox ESR 52, which never got the Normandy client.
Notably, when we dropped support for Windows XP from Firefox, we put all
XP users onto ESR 52, so we are not likely to be able to remove this
endpoint any time soon.

Fixes mozilla#1563
bors bot added a commit that referenced this issue Oct 4, 2018
1569: Increase cache on deprecated self-repair to one week r=sciurus a=mythmon

This view serves a message that the system is no longer active. We keep it around because it is still gets about 40 million hits per day, primarily from Firefox ESR 52, which never got the Normandy client. Notably, when we dropped support for Windows XP from Firefox, we put all XP users onto ESR 52, so we are not likely to be able to remove this endpoint any time soon.

Fixes #1563

Co-authored-by: Mike Cooper <mythmon@gmail.com>
@bors bors bot closed this as completed in #1569 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants