Allow downstreams to upgrade to Windows 0.59 #2662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 2fc82fd. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
|
The last commit might need to be omitted, pending proof that the latest version actually compiles. |
Benchmark results1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold. time: [760.94 ms 788.79 ms 818.47 ms]
thrpt: [122.18 MiB/s 126.78 MiB/s 131.42 MiB/s]
change:
time: [−11.209% −6.0606% −0.6973%] (p = 0.03 < 0.05)
thrpt: [+0.7022% +6.4516% +12.624%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [314.65 ms 315.96 ms 317.27 ms]
thrpt: [31.519 Kelem/s 31.649 Kelem/s 31.781 Kelem/s]
change:
time: [−0.9201% −0.3799% +0.1884%] (p = 0.18 > 0.05)
thrpt: [−0.1881% +0.3813% +0.9286%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.545 ms 35.787 ms 37.027 ms]
thrpt: [27.007 elem/s 27.943 elem/s 28.948 elem/s]
change:
time: [−4.8421% +0.0685% +5.2570%] (p = 0.98 > 0.05)
thrpt: [−4.9945% −0.0685% +5.0885%]
1-conn/1-100mb-req/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [7.3247 s 7.3374 s 7.3500 s]
thrpt: [13.605 MiB/s 13.629 MiB/s 13.652 MiB/s]
change:
time: [+0.5088% +0.7758% +1.0342%] (p = 0.00 < 0.05)
thrpt: [−1.0236% −0.7699% −0.5062%]
decode 4096 bytes, mask ff: 💚 Performance has improved. time: [11.636 µs 11.648 µs 11.660 µs]
change: [−1.8845% −1.7549% −1.6211%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.9767 ms 2.9790 ms 2.9811 ms]
change: [−1.9004% −1.7426% −1.5899%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: 💚 Performance has improved. time: [19.425 µs 19.438 µs 19.450 µs]
change: [−2.9813% −2.8102% −2.6426%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.9749 ms 4.9770 ms 4.9788 ms]
change: [−2.6305% −2.4697% −2.2811%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💚 Performance has improved. time: [5.5515 µs 5.5592 µs 5.5668 µs]
change: [−33.227% −33.106% −32.981%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💚 Performance has improved. time: [1.4232 ms 1.4253 ms 1.4275 ms]
change: [−30.959% −29.541% −28.037%] (p = 0.00 < 0.05)
1000 streams of 1 bytes/multistream: 💚 Performance has improved. time: [14.107 ns 14.464 ns 15.145 ns]
change: [−15.612% −13.389% −9.3107%] (p = 0.00 < 0.05)
1000 streams of 1000 bytes/multistream: 💚 Performance has improved. time: [14.015 ns 14.053 ns 14.093 ns]
change: [−13.837% −13.450% −13.061%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [95.021 ns 95.180 ns 95.330 ns]
change: [−0.6872% −0.0572% +0.5809%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [112.86 ns 112.99 ns 113.10 ns]
change: [−0.2025% +0.3973% +0.9397%] (p = 0.16 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [111.62 ns 111.81 ns 111.98 ns]
change: [−0.4717% +0.1017% +0.6741%] (p = 0.74 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [89.114 ns 89.544 ns 90.407 ns]
change: [−2.1253% −0.4974% +0.5219%] (p = 0.66 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.26 ms 111.27 ms 111.29 ms]
change: [+0.4052% +0.4261% +0.4474%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [9.4279 µs 9.4897 µs 9.5519 µs]
change: [−3.9277% −1.2850% +1.4468%] (p = 0.35 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [34.043 ms 34.074 ms 34.106 ms]
change: [+1.1928% +1.3325% +1.4701%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.698 ms 34.746 ms 34.796 ms]
change: [−0.0978% +0.0951% +0.2971%] (p = 0.36 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.104 ms 34.125 ms 34.147 ms]
change: [+1.1873% +1.2965% +1.4053%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [36.004 ms 36.032 ms 36.059 ms]
change: [+1.9469% +2.0751% +2.2024%] (p = 0.00 < 0.05)
Client/server transfer resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
|
mxinden
reviewed
May 24, 2025
Comment on lines
-37
to
+39
| quinn-udp = { version = "0.5.11", default-features = false, features = ["direct-log"] } | ||
| quinn-udp = { version = "0.5.11", default-features = false, features = [ | ||
| "direct-log", | ||
| ] } |
There was a problem hiding this comment.
Please don't include unrelated changes, i.e. here formatting changes.
Comment on lines
-1397
to
+1385
| version = "0.58.0" | ||
| version = "0.59.0" |
There was a problem hiding this comment.
While github.com/mozilla-firefox/firefox is on windows 0.58.0, I would prefer Neqo to stay on windows 0.58.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.