Update CONTRIBUTING.md #2661
Open
Update CONTRIBUTING.md #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding tips of contributing
couci
commented
Aug 22, 2024
| ##Tips for contributing: | ||
|
|
||
| * Choose an issue from https://github.com/mozilla/multi-account-containers/issues that you would like to work on. | ||
| * Fork the repository and follow the instructions for setting it up locally. |
There was a problem hiding this comment.
better add "instructions above" to make it clearer
rafeerahman
suggested changes
Aug 23, 2024
| @@ -36,3 +36,15 @@ You can then [open a pull request][pr] on [the l10n repository][l10n]. | |||
| [l10n]: https://github.com/mozilla-l10n/multi-account-containers-l10n/ | |||
| [pr]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests | |||
| [web-ext]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Getting_started_with_web-ext | |||
|
|
|||
| ##Tips for contributing: | |||
There was a problem hiding this comment.
Suggested change
| ##Tips for contributing: | |
| ## Tips for contributing: |
| * Run the add-on locally and try reproducing the issue. | ||
| * Debug add-ons by clicking the “Settings” icon in about:addons, and then clicking “Debug Add-ons” | ||
| * Click “Inspect” on the MAC add-on to open developer tools for the popup extension (see https://extensionworkshop.com/documentation/develop/debugging/ for more information) | ||
| * Once you have a fix ready, commit your changes with the following template |
There was a problem hiding this comment.
Suggested change
| * Once you have a fix ready, commit your changes with the following template | |
| * Once you have a fix ready, commit your changes with the following commit message template |
| * Debug add-ons by clicking the “Settings” icon in about:addons, and then clicking “Debug Add-ons” | ||
| * Click “Inspect” on the MAC add-on to open developer tools for the popup extension (see https://extensionworkshop.com/documentation/develop/debugging/ for more information) | ||
| * Once you have a fix ready, commit your changes with the following template | ||
| * “Fix #<insert issue id #>: <description>” |
There was a problem hiding this comment.
Suggested change
| * “Fix #<insert issue id #>: <description>” | |
| * “Fix #<insert issue id #>: <description>” |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding tips of contributing
Before submitting your pull request
Description
Please include a summary of the changes including relevant motivation and context.
Type of change
Added extra tips on contributing file