feat #303: ask for browsing data permission dynamically

mozilla · Aug 27, 2024 · bdae43e · bdae43e
1 parent 2cd3829
commit bdae43e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/js/popup.js b/src/js/popup.js
@@ -980,7 +980,7 @@ Logic.registerPanel(P_CONTAINER_INFO, {
       Utils.alwaysOpenInContainer(identity);
       window.close();
     });
-    
+
     // Show or not the has-tabs section.
     for (let trHasTabs of document.getElementsByClassName("container-info-has-tabs")) { // eslint-disable-line prefer-const
       trHasTabs.style.display = !identity.hasHiddenTabs && !identity.hasOpenTabs ? "none" : "";
@@ -1005,8 +1005,13 @@ Logic.registerPanel(P_CONTAINER_INFO, {
       Logic.showPanel(P_CONTAINER_EDIT, identity);
     });
     const clearContainerStorageButton = document.getElementById("clear-container-storage-info");
-    Utils.addEnterHandler(clearContainerStorageButton, () => {
-      Logic.showPanel(P_CLEAR_CONTAINER_STORAGE, identity);
+    Utils.addEnterHandler(clearContainerStorageButton, async () => {
+      const requiredPermission = { permissions: ["browsingData"] };
+      const granted = await browser.permissions.request(requiredPermission);
+
+      if (granted) {
+        Logic.showPanel(P_CLEAR_CONTAINER_STORAGE, identity);
+      }
     });
     return this.buildOpenTabTable(tabs);
   },

diff --git a/src/manifest.json b/src/manifest.json
@@ -13,7 +13,6 @@
     "<all_urls>",
     "activeTab",
     "cookies",
-    "browsingData",
     "contextMenus",
     "contextualIdentities",
     "history",
@@ -27,6 +26,7 @@
   ],
   "optional_permissions": [
     "bookmarks",
+    "browsingData",
     "nativeMessaging",
     "proxy"
   ],