Fix clippy::legacy_numeric_constants lint on nightly
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baumanj
changed the title
clippy::legacy_numeric_constants lint on nightly
baumanj
force-pushed
the
fix-clippy-legacy_numeric_constants
branch
from
9af5490 to
b88c09e
Compare
baumanj
force-pushed
the
fix-clippy-legacy_numeric_constants
branch
from
b88c09e to
898768f
Compare
|
Thanks Jon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://rust-lang.github.io/rust-clippy/master/index.html#/legacy_numeric_constants
Hopefully this fixes https://github.com/mozilla/mp4parse-rust/actions/runs/8598206617/job/23558557224
I couldn't reproduce it locally, but the fix didn't seem to break either stable or nightly locally either, so I figure if this passes CI, it should fix the issue.