Ignore unused trailing data in mvhd.
#416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinetiknz
force-pushed
the
mvhd_trailing
branch
from
096075c to
838dcc1
Compare
|
We need to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses BMO 1867424, where the linked media contains an unusual
mvhdwith 2 bytes of trailing data. Sincemvhdhas a fixed set of fields, we were expecting themvhdsize to match the spec based on the size of the known fields (108 bytes for this v0 file, v1 would be larger due to 64-bit fields) but themvhdbox size is 110 bytes in this file. To address this, we now skip the remaining unknown bytes based on the box's reported size.