Add HEVC support. #408
Closed
Add HEVC support. #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can a maintainer let us know if you are interested in that addition? If not we'll move to a fork but we'd prefer not to. |
|
Apologies for the delay, I'll review this tomorrow. |
|
Hmm I didn't notice that we already had this PR for HEVC, so I also made another one in #410. @kinetiknz maybe you can review them to see if we should combine them together, or just use one of them. Thanks! |
|
Sorry about the confusion - I've reviewed both PRs and have merged the result now. I used PR 410 as the base since this will be used in Gecko, so we don't need to hide it behind a feature flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add H.265 support by identifying 'hev1' or 'hvc1' entry and also extracting extradata from 'hvcC' box. The logic is very similar to H.264.