Skip to content

Move UnexpectedEOF handling back to the BoxIter. #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Move UnexpectedEOF handling back to the BoxIter. #403

merged 1 commit into from
Apr 13, 2023
+11 −12

Conversation

kinetiknz
Copy link
Collaborator

This should fix the regression found by Gecko's ZeroInLastMoov GTest.

@kinetiknz kinetiknz self-assigned this Apr 13, 2023
@kinetiknz kinetiknz force-pushed the partial_revert_eof_handling branch from 7cd40f3 to 6df62a4 Compare April 13, 2023 05:12
@kinetiknz kinetiknz requested a review from padenot April 13, 2023 05:16
padenot
padenot approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the test indeed, thanks!

@padenot padenot merged commit cf8b0e0 into mozilla:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot approved these changes

Assignees

@kinetiknz kinetiknz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinetiknz @padenot