Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support -drop in jpegtran #343

Closed
lovasoa opened this issue Aug 16, 2019 · 3 comments
Closed

support -drop in jpegtran #343

lovasoa opened this issue Aug 16, 2019 · 3 comments

Comments

@lovasoa
Copy link

lovasoa commented Aug 16, 2019

The original jpegtran has a nice -drop option that allows joining two jpeg files together losslessly:
https://jpegclub.org/jpegtran/

Would it be in the scope of this project to implement the same in mozjpeg ?

@kornelski
Copy link
Member

This looks like an extension from the "v9" fork of libjpeg.

I'd prefer to keep MozJPEG as close as possible to libjpeg-turbo, so try getting the change into libjpeg-turbo.

@lovasoa
Copy link
Author

lovasoa commented Aug 19, 2019

It looks like it has been proposed to libjpeg-turbo, and refused in libjpeg-turbo/libjpeg-turbo#71.

Does that mean it has no chance of being integrated in mozjpeg ? That would be a pitty, because I think it is so only piece of code that allows joining jpeg files losslessly, and it's old and unmaintained.

@kornelski
Copy link
Member

kornelski commented Aug 19, 2019

If libjpeg-turbo doesn't want it, then I'd rather not add it either. Adding it to MozJPEG wouldn't change anything about it being old and unmaintained. MozJPEG would be worse off for having more old and unmaintained code.

kornelski pushed a commit that referenced this issue Feb 26, 2021
This commit modifies the behavior of the block smoothing algorithm in
the libjpeg API library so that, if a scan in a multi-scan JPEG image is
incomplete (due to premature termination of the image stream), the block
smoothing parameters from the previous (complete) scan are used to
smooth any iMCU rows that the incomplete scan does not contain.

Closes #343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants