This repository has been archived by the owner on Mar 5, 2020. It is now read-only.
Created pages directory to separate top level pages from components #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toolness what do you think? |
|
Oh, that's funny, we actually originally planned to do this a little while ago but I got cold feet--I think now that the codebase has matured, though, it is probably a good idea indeed! |
|
Hahaha! That's pretty funny @toolness |
|
@k88hudson I hadn't noticed you opened this PR, but it definitely addresses 50% of #350. Feel free to add the Less portion to this PR, but if you chose not to that's fine and we can just leave #350 open. |
|
@gesa I'd prefer to merge quickly after rebasing, feel free to address less separately |
k88hudson
force-pushed
the
page-organization
branch
from
ed9e56d
to
b229585
Compare
|
@gesa ok rebase is done. want to review? |
|
Woo this looks good to me so far! @gesa if you are happy w/ things feel free to merge! |
|
I am thrilled, R+ |
k88hudson
added a commit
that referenced
this pull request
Mar 20, 2015
Created pages directory to separate top level pages from components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know technically there is no distinction between pages and components in React, but I personally I think making the distinction is worth doing. IMO It helps reveal what components are available and prevents duplication of work.
Note that I haven't reorganized the LESS accordingly, I figured I would submit this PR first to see what your thoughts are