Add rid
to logs with asgi-correlation-id
#782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
asgi-correlation-id
, which provides a filter to add a request id (what they call a "correlation id") to logs by using aContextVar
.Here's an example when calling
__heartbeat__
, where I didn't take too much care in settings configuration properly (I also patched the heartbeat route handler -- more on that in another PR)One note: the
rid
does not seem to be preserved in instances where we use aThreadPoolExecutor
. I believe this is a limitation of Context Vars. We can investigate how to copy this context to other threads in a future PR, but this seems "good enough" for now, and we have other ways to diagnose what's going on in the heartbeat