-
Notifications
You must be signed in to change notification settings - Fork 23
Update to remote-link title; use URL, set icon favicon url. #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@grahamalama do you think we should move forward with something like this? (If so, we can look into modifying the atlassian-python-api to add the |
Yeah, since the client library doesn't support adding favicons and we're already adding some more context requested in #202 (i.e.
EDIT: it looks like
|
@bsieber-mozilla I ended up submitting atlassian-api/atlassian-python-api#1040 since it was a pretty straightforward change |
5225d94
to
a481fb8
Compare
@grahamalama thanks for the addition; I've pointed to the new commit hash to pick those changes up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to set icon_title
as well?
Also, could you create an issue to revert back to PyPI-released version of atlassian-python-api
once that patch makes it into the next release?
When looking at the API and testing this adds a tooltip, but isn't essential (just like I'll add it in though
Good callout. Currently the toml is pointed to the previous commit when our team last updated the Followup: |
#202
After testing locally, this doesn't add the favicon--but is one step closer to what was previously expected.
The atlassian-python-api does not accept "icon" as part of the api, however if we use the Jira REST API, we should be able to add a link to a favicon.