Skip to content

Reducing jira char limit by 100 so Jira doesn't overrun this when closing tags #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

alexcottner
Copy link
Contributor

@alexcottner alexcottner commented Apr 28, 2025

We ran into an issue today with a code block getting truncated when writing to Jira. Jira then tried to close the code block out with thee more characters to make the markdown valid, which then exceeded the character limit.

If we're already truncating we can cut off a few more characters to allow for this to happen without exceeding the limit.

Link to alert thread.

@alexcottner alexcottner requested a review from a team as a code owner April 28, 2025 17:36
@alexcottner alexcottner added the bug Something isn't working label Apr 28, 2025
Copy link

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reasoning on truncating 100 more char? Also is it worth maybe adding a text that says the full description was not copy-pasted due to char limit?

@alexcottner
Copy link
Contributor Author

alexcottner commented Apr 28, 2025

Any reasoning on truncating 100 more char? Also is it worth maybe adding a text that says the full description was not copy-pasted due to char limit?

The 100 characters is just to give plenty of room to let Jira close out any hanging elements. Really 4 characters should be enough, but nested code blocks are a thing and 32,667 still seems like a lot of context.

We could add something like {truncated...} to the end. But I was hoping to make this a quick fix and not change existing behavior.

@alexcottner alexcottner requested a review from say-yawn April 28, 2025 17:51
Copy link

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, quick fix is fine.

@alexcottner alexcottner merged commit 7ba3ce0 into main Apr 28, 2025
8 of 9 checks passed
@alexcottner alexcottner deleted the reduce-char-limit branch April 28, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants