Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Jul 13, 2021

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't adding anything but the most basic parsing.
I assume because it's that easy it won't require any template changes, correct?

@brizental
Copy link
Contributor Author

This isn't adding anything but the most basic parsing.
I assume because it's that easy it won't require any template changes, correct?

Exactly. This is how the generated code looks like:

import UrlMetricType from "@mozilla/glean/webext/private/metrics/url";
/**
 * ...
 *
 * Generated from `telemetry.test`.
 */
export const test = new UrlMetricType({
    category: "telemetry",
    name: "test",
    sendInPings: ["metrics"],
    lifetime: "user",
    disabled: false,
});

@badboy
Copy link
Member

badboy commented Jul 13, 2021

This isn't adding anything but the most basic parsing.
I assume because it's that easy it won't require any template changes, correct?

Exactly. This is how the generated code looks like:

import UrlMetricType from "@mozilla/glean/webext/private/metrics/url";
/**
 * ...
 *
 * Generated from `telemetry.test`.
 */
export const test = new UrlMetricType({
    category: "telemetry",
    name: "test",
    sendInPings: ["metrics"],
    lifetime: "user",
    disabled: false,
});

It's like we planned for this!

@brizental brizental merged commit 5c630b1 into main Jul 13, 2021
@brizental brizental deleted the 1719315-url branch July 13, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants