Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Apr 8, 2021

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@mdboom
Copy link
Contributor Author

mdboom commented Apr 8, 2021

Well, now we know 3.10 doesn't work yet (due to some dependencies not working yet). No urgency to getting this merged, but we can keep this PR alive to test against 3.10 periodically.

@mdboom mdboom requested a review from chutten April 15, 2021 15:41
@mdboom
Copy link
Contributor Author

mdboom commented Apr 15, 2021

Fixes have been made to upstream projects, so this is working now.

Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdboom mdboom merged commit 848b436 into mozilla:main Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants