Bug 1692157 - Update Javascript templates and provide Typescript template #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsHISTORY.rstor an explanation of why it does not need oneTurns out just changing the file extension was easier than providing type declaration files 👀
Reference:
Note that Javascript template and Typescript template are the same, the only change is in the file extension (well, and also an extra
"use strict"statement on the Javascript template). I have tested that with both sample extension over on the Glean.js project and it worked.