Skip to content

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Apr 5, 2021

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 April 5, 2021 19:25
@mdboom mdboom requested review from chutten and removed request for Dexterp37 April 5, 2021 19:25
@mdboom
Copy link
Contributor Author

mdboom commented Apr 6, 2021

Gah -- this reveals a bug in the glean_parser schema -- the glean_* ping names are no longer special-case allowed. This is only a problem for glean itself, since these aren't allowed for third-party projects anyway, but we'll need to go ahead and update glean_parser and ship a release etc. to make this PR work.

@mdboom
Copy link
Contributor Author

mdboom commented Apr 6, 2021

Blocked by mozilla/glean_parser#301

mdboom added a commit to mdboom/glean_parser that referenced this pull request Apr 6, 2021
mdboom added a commit to mozilla/glean_parser that referenced this pull request Apr 6, 2021
* Update schema to allow for "special" glean_* pings

See mozilla/glean#1572

* Move special case to `send_in_pings` only
@badboy badboy closed this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants