[ALTERNATE] Bug 1689547 - Create plugin / events infrastructure and define afterPingCollection event
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Mar 4, 2021
brizental
commented
Mar 4, 2021
brizental
commented
Mar 4, 2021
brizental
force-pushed
the
1689547-plugins-ALTERNATE
branch
from
21ff67e to
d2f7348
Compare
added 3 commits
March 4, 2021 15:05
Dexterp37
approved these changes
Mar 4, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
I like this approach more than the previous one, thanks for taking time to go through this again. I appreciate the effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different approach for #94 (and my preferred approach, 1) Less cleverness on the types 2) Less relying on the Glean singleton).
Based off of this thread.