Skip to content

Bug 1702251 - Don't rely on Glean internals on plugins tests #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Bug 1702251 - Don't rely on Glean internals on plugins tests #923

merged 1 commit into from
Nov 18, 2021

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Nov 5, 2021

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from mdboom November 5, 2021 09:52
@brizental brizental requested review from badboy and removed request for mdboom November 18, 2021 09:47
@brizental brizental merged commit 913004e into mozilla:main Nov 18, 2021
@brizental brizental deleted the 1702251-no-internals-in-tests branch November 18, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badboy badboy badboy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brizental @badboy