Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Oct 18, 2021

In this PR I only enpose the entry point. Actual implementation of the web platform will come in the next PRs.

Also, is it confusing to call the website entry point web?

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from mdboom October 18, 2021 12:45
Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Regarding your question about the entrypoint "web", maybe "browser" is clearer? But I'm not strongly opposed to "web" either.

@brizental
Copy link
Contributor Author

Regarding your question about the entrypoint "web", maybe "browser" is clearer

I worry that browser would be confusing because webext folks may think that is their entry point as well. However, web has the same issue hah.

@brizental brizental merged commit b953902 into mozilla:main Oct 18, 2021
@brizental brizental deleted the 1736346-web-entry branch October 18, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants