Bug 1708194, 1734731 - Write tests on Qt sample and run them on CI #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
changed the title
Our only Qt consumer is in C++ so it makes more sense to have it like this. I decided against keeping both sample to minimize amount of code we need to maintain.
1. Expose ErrorType 2. Fix version of LocalStorage plugin 3. Fix the way to access the lib from inside the shutdown file 4. Expose testRestGlean
brizental
force-pushed
the
1708194-qt-tests
branch
from
8068389 to
c4117c6
Compare
Contributor
Author
|
We can ignore the linter error which is unrelated to this PR. It is related to audit issues with dependencies of our dependencies (test-only). There needs to be some investigation on how to approach that. Bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1734888 |
brizental
changed the title
badboy
approved these changes
Oct 11, 2021
| qtbase5-dev qt5-default qt5-qmake qttools5-dev-tools qtdeclarative5-dev \ | ||
| qtdeclarative5-dev-tools qml-module-qttest qml-module-qtquick2 \ | ||
| qml-module-qtquick-localstorage qml-module-qtquick-controls2 | ||
| sudo apt-get install xvfb |
Member
There was a problem hiding this comment.
Why's that separate and not part of the first apt-get install?
Contributor
Author
There was a problem hiding this comment.
Eh, no reason really. It is not direcly Qt related, and I added it at a different time during development.
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work