Bug 1732294 - If initialization errors Glean doesn't do anything else #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes things easier to debug.
+ Some clean up work on the Dispatcher.execute() method. That switch statement was _confusing_.
The log command was only accepting strings, which was not ideal because it made it hard to log errors and stack traces and also console.* function accept anything so our log command should do the same anyways. In this commit I also audit all the other places we logged errors outside of the dispatcher in order to make sure we are now logging useful stack traces along with error messages.
brizental
changed the title
badboy
reviewed
Oct 11, 2021
badboy
approved these changes
Oct 11, 2021
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need one