Fix publish step #780
Merged
Fix publish step #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think you'll need to make a test tag of this to see if it's actually solved the issue. |
mdboom
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On tagging 0.21.0 the
publish to npmstep failed in CI due tonpm build:webextnot being available.This commit d73a93f#diff-509bb202baa8df0d26bbf11ae91491e2b3a9ae00a1b7528aa215ad5941c9909cL79 removed
build:webextbut did not remove the call to it in theprePublishOnlyscript.Also, worth noting that refs to
build:webextare inbenchmarks/package.jsonbut I have not fixed those in this PR as I don't know the best replacement.