Bug 1727349 - Drop _getWholeStore API from Store impls #681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remember we were hesistant to alllow getting the whole stire and that is the reason why it was put into a special function and the underline was added. Initially the idea was that it would be used only in tests. The `get` should then throw an error when it got an empty index. Turns out not all store implementations (namely webext and tests) were throwing this error and there were two places in the code (outside of tests) where we were getting the whole store. These places were the events database, when getting all store names, and the pings database, when scanning the database. The cause of the initialization error in Qt was that in the events database code we were trying to get the whole store by passing an empty index to the `get` API. Qt being the only spec compliant, was throwing an error when that happened.
Dexterp37
approved these changes
Aug 30, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Oh gee, Bea. Great commit messages. Thank you.
r+ with a changelog entry added.
Contributor
Author
Thanks! Quick note, the changes in this PR fix on partially the issues I mentioned in todays meeting related to the events sorting not working properly (or at all) in the samples. I have filed a bug to investigate that tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersChangelog: This PR includes a changelog entry toCHANGELOG.mdor an explanation of why it does not need oneDocumentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work