Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Aug 16, 2021

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work
    • This behaviour is already documented on the Glean book, although looking at the docs I think they might benefit from having examples for quantity and boolean extra types too. I'll follow-up with a PR to the Glean book updating it.

Opening as a draft: I'll make the necessary changes to glean_parser and then update glean_parser in this PR before it is ready.

@brizental brizental force-pushed the 1693487-event-extras branch from a3cdbd4 to 59116ca Compare August 16, 2021 15:24
@brizental brizental marked this pull request as ready for review August 18, 2021 14:09
@brizental brizental requested a review from Dexterp37 August 18, 2021 14:09
@brizental
Copy link
Contributor Author

This with the glean_parser update is pretty neat. See:

Screenshot 2021-08-18 at 16 00 47

Screenshot 2021-08-18 at 16 01 16

@brizental brizental merged commit dc544dd into mozilla:main Aug 18, 2021
@brizental brizental deleted the 1693487-event-extras branch August 18, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants