-
Notifications
You must be signed in to change notification settings - Fork 34
Bug 1702206: Refactor Uploader into class for external use #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update CHANGELOG.md
brizental
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @ChinYing-Li ! This looks great. I left some very minor comments, but otherwise this is good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @ChinYing-Li ! Looks great :D Would you mind rebasing it so I can merge?
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lint && npm run lint:circular-depsRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepositoryThis PR aims to tackle bug 1702206; no new test added but some test cases have been modified.
Please ignore my question on Bugzilla, as I now understand why this approach is preferred. PR ready for review,
and will modify. Thanks!CHANGELOG.mdif there's no problem