Skip to content

Conversation

@ChinYing-Li
Copy link
Contributor

@ChinYing-Li ChinYing-Li commented Jul 17, 2021

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

This PR aims to tackle bug 1702206; no new test added but some test cases have been modified.
Please ignore my question on Bugzilla, as I now understand why this approach is preferred. PR ready for review, and will modify CHANGELOG.md if there's no problem. Thanks!

@brizental brizental self-requested a review July 19, 2021 07:55
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @ChinYing-Li ! This looks great. I left some very minor comments, but otherwise this is good to go.

@brizental brizental self-requested a review July 20, 2021 15:36
Copy link
Contributor

@brizental brizental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @ChinYing-Li ! Looks great :D Would you mind rebasing it so I can merge?

@brizental brizental merged commit 66737d8 into mozilla:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants