Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Jul 5, 2021

Fun fact: we basically never reach this limit with glean-core.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@brizental brizental requested a review from badboy July 5, 2021 16:01
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but otherwise looks straight forward.

@brizental brizental merged commit c0b139b into mozilla:main Jul 6, 2021
@brizental brizental deleted the 1712922-ping-body-limit branch July 6, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants