-
Notifications
You must be signed in to change notification settings - Fork 34
Bug 1681483 - Implement persistent storage for QML #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Converted to draft because somehow running the QML tests make it so that the WebExt storage tests are not run (and also don't error, thus the green CI). This PR is ready for review on the QML side though. |
|
Ok, the Storage/WebExt error is not related, and actually might be happening for a while /o\ It is also happening on the events threshold PR. Filed a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1717845 |
Build size report
|
Dexterp37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+, the handle thing can be done in a follow-up and reviewed by @badboy if needed.
efe5868 to
1a43cac
Compare
See: https://glean-debug-view-dev-237806.firebaseapp.com/pings/brzntl-from-qml
The two pings with that tag were sent from different application runs 🎉
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lint && npm run lint:circular-depsRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepository