Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Jun 23, 2021

See: https://glean-debug-view-dev-237806.firebaseapp.com/pings/brzntl-from-qml

The two pings with that tag were sent from different application runs 🎉

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@brizental brizental requested a review from Dexterp37 June 23, 2021 13:13
@brizental brizental marked this pull request as draft June 23, 2021 13:16
@brizental
Copy link
Contributor Author

Converted to draft because somehow running the QML tests make it so that the WebExt storage tests are not run (and also don't error, thus the green CI).

This PR is ready for review on the QML side though.

@brizental brizental marked this pull request as ready for review June 23, 2021 14:02
@brizental
Copy link
Contributor Author

Ok, the Storage/WebExt error is not related, and actually might be happening for a while /o\ It is also happening on the events threshold PR.

Filed a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1717845

@moz-glean
Copy link
Collaborator

Build size report

Merging #462 into main will:

  • Leave the size of full Web Extension bundle unchanged.
  • Increase the size of full Qt/QML bundle build by 4%.

Current size New size Size increase
Web Extension
core only 45 KB 45 KB 📈 75 bytes
full bundle 67 KB 67 KB 📈 75 bytes
Qt/QML
core only 104 KB 109 KB 📈 4.4 KB
full bundle 104 KB 109 KB 📈 4.4 KB

@brizental brizental requested a review from Dexterp37 June 24, 2021 10:05
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, the handle thing can be done in a follow-up and reviewed by @badboy if needed.

@brizental brizental force-pushed the 1681483-qml-storage branch from efe5868 to 1a43cac Compare June 25, 2021 08:22
@brizental brizental merged commit 070c33d into mozilla:main Jun 25, 2021
@brizental brizental deleted the 1681483-qml-storage branch June 25, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants