Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Jun 17, 2021

This is blocked until a new version fflate is out with these changes: 101arrowz/fflate#75

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/folder, run:
      • npm run test Runs all tests
      • npm run lint && npm run lint:circular-deps Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

Copy link

@101arrowz 101arrowz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a few comments regarding the usage of fflate.

@brizental
Copy link
Contributor Author

New fflate version not required, as discussed in 101arrowz/fflate#75 (comment)

This is ready for review. Already tested on the debug viewer, look for tag monday-qml-gzipping heh.

@brizental brizental removed the blocked label Jun 21, 2021
@brizental brizental requested a review from Dexterp37 June 21, 2021 15:34
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quite a Mistery. Thank you Bea and thanks @101arrowz .

@brizental please add a changelog entry before merging.

@brizental brizental merged commit 3a281e7 into mozilla:main Jun 21, 2021
@brizental brizental deleted the 1716322-qml-gzip branch June 21, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants