Bug 1712285 - Tag all log messages #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1712285-logging
branch
from
42fbab0 to
f432a33
Compare
Dexterp37
reviewed
Jun 9, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
r+ with a changelog entry added.
Dexterp37
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to easily add functionality to turn debug logs off. Filed a bug for it: https://bugzilla.mozilla.org/show_bug.cgi?id=1715312
We should also audit the levels of these messages, some messages are internal error but are in the Error level. They should really be debug, or trace... Anyways, that can be done as part of the but I created above.