Bug 1688902 - Create the events metric type #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the `test:unit` npm script, which quickly runs all the unit tests.
This field is required, but it can be an empty string.
This is modeled after the events database in the Glean SDK (without the append-only file).
This is the primary API for dealing with events.
Change the payload structure to declare them as an array instead of an object.
Dexterp37
commented
Feb 2, 2021
src/metrics/events_database.ts
Outdated
| private eventsStore: Store; | ||
|
|
||
| constructor() { | ||
| this.eventsStore = new WeakStore("unused"); |
Contributor
Author
There was a problem hiding this comment.
This should probably use the persistent storage :-P
Contributor
There was a problem hiding this comment.
Hey, I think this one was missed :)
Dexterp37
commented
Feb 2, 2021
brizental
suggested changes
Feb 3, 2021
brizental
suggested changes
Feb 3, 2021
src/metrics/events_database.ts
Outdated
| private eventsStore: Store; | ||
|
|
||
| constructor() { | ||
| this.eventsStore = new WeakStore("unused"); |
Contributor
There was a problem hiding this comment.
Hey, I think this one was missed :)
src/metrics/events_database.ts
Outdated
| ): Promise<RecordedEvent[] | undefined> { | ||
| const events = await this.getAndValidatePingData(ping); | ||
| if (events.length === 0) { | ||
| return undefined; |
Contributor
There was a problem hiding this comment.
uber nit: If you change the return type to Promise<RecordedEvent[] | void> you can do just return; here.
brizental
approved these changes
Feb 3, 2021
src/metrics/events_database.ts
Outdated
|
|
||
| constructor() { | ||
| this.eventsStore = new WeakStore("unused"); | ||
| this.eventsStore = new PersistentStore("unused"); |
Contributor
There was a problem hiding this comment.
"unused" may not the most descriptive storage name. Maybe "events"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages descriptions for easier review.
This exclusively adds the metric type, it doesn't take care of adding the 'events' ping.