Skip to content

Conversation

@ChinYing-Li
Copy link
Contributor

The PR aims to tackle bug 1681484;
Right now, package-lock.json is intentionally modified to see whether the newly added CI check fails as expected.

@ChinYing-Li ChinYing-Li force-pushed the bug_1681484 branch 3 times, most recently from 30585aa to 9531ff8 Compare May 12, 2021 18:12
@ChinYing-Li
Copy link
Contributor Author

Upon testing, the check Check that package-lock.json is updated as needed does work.
Here are my steps for testing the CI script:

  1. I committed a package-lock.json with one dependency manually removed from it
  2. Run the CI, and the CI fails by showing the diff between the CI-generated package-lock.json and the committed package-lock.json.

PR ready for review, and any suggestion is appreciated! @brizental

Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This worked already :-D see this CI check.

@Dexterp37 Dexterp37 merged commit 70a2b6c into mozilla:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants