Bug 1687491 - Implement a dispatcher and add an instance to the Glean singleton #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
brizental
commented
Jan 26, 2021
Dexterp37
requested changes
Jan 27, 2021
brizental
commented
Jan 27, 2021
| // | ||
| // TODO: Bug 1687491 might resolve this issue. | ||
| // This is safe. | ||
| // Since the dispatcher is stopped, no external API calls will be executed. |
Contributor
Author
There was a problem hiding this comment.
Isn't this nice? The dispatcher actually fixed the issue. Now, it will only really be fixed after my next PR when the recording calls are indeed dispatched.
Dexterp37
approved these changes
Jan 27, 2021
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1.
Other PRs will come for actually using this dispatcher on the external APIs.