Bug 1709312: Introduce QuantityMetric #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
May 5, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
This looks really good already, thanks for doing it!
I have a few minor requests, below.
| } | ||
|
|
||
| /** | ||
| * Sets to the specified quantity value. |
Contributor
There was a problem hiding this comment.
Would you kindly add some more details here? For reference, here's the Rust trait for this same type.
Dexterp37
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to solve bug 1709312.
TODO: examples of JavaScript API should be added to https://github.com/mozilla/glean/blob/main/docs/user/reference/metrics/quantity.md
Any suggestion is appreciated!