Bug 1708366: Ensure only empty pings triggers logging of "empty ping" message

[ChinYing-Li]

I think the original logic is wrong, in that the message Storage for ${ping.name} empty. Ping will still be sent. will be logged if eventsData is defined.

glean.js/glean/src/core/pings/maker.ts

Lines 198 to 203 in 0557f31

	if (!metricsData && !eventsData && !ping.sendIfEmpty) {
	console.info(`Storage for ${ping.name} empty. Bailing out.`);
	return;
	} else if (!metricsData) {
	console.info(`Storage for ${ping.name} empty. Ping will still be sent.`);
	}

[Dexterp37]

Good catch! Yes, the logic was wrong before. Great PR!