Bug 1687644 - Implement the external API for consumers #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The Qt error seems unrelated. I will verify, but don't feel that it blocks the review :) |
Dexterp37
requested changes
Jan 21, 2021
| if (isObject(target) && key in target) { | ||
| target = target[key]; | ||
| const temp: unknown = target[key]; | ||
| if (isJSONValue(temp)) { |
Contributor
There was a problem hiding this comment.
Did you stumble upon non-JSON values being stored?
Contributor
Author
There was a problem hiding this comment.
Nope, but we can and typescript compilation errors because it knows we can. It requires that we guarantee that the type is correct.
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
That is a browser API and fails at Qt/QML envs.
brizental
force-pushed
the
1687644-external-api
branch
from
e81a250 to
bea1bd6
Compare
Contributor
Author
|
The Qt problems were actually related. We were using some browser APIs namely URL and crypto, which I didn't realize before. That was fixed. This is ready for a new look. |
Dexterp37
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can acutally measure it, for reference: