Bug 1699391: Add a spinner to the console output while setting up python virtual env #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChinYing-Li
force-pushed
the
bug_1699391
branch
from
4de3cd6 to
91ce2e8
Compare
brizental
suggested changes
Apr 30, 2021
Contributor
brizental
left a comment
brizental
left a comment
There was a problem hiding this comment.
Big fan of this change. Great job @ChinYing-Li !
Left a few comments but nothing major :D
ChinYing-Li
changed the title
…nv (mozilla#261) Address the comments
ChinYing-Li
force-pushed
the
bug_1699391
branch
from
91ce2e8 to
67756f8
Compare
Contributor
Author
|
Once this PR is good to go, I will rebase it to resolve the conflicts.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to tackle bug 1699391, by running a spinner in the console during the creation of the python virtual environment.
Any suggestion is appreciated!