Skip to content

Remove outdated comment from Glean.initialize #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Remove outdated comment from Glean.initialize #259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions glean/src/core/glean.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,6 @@ class Glean {
/**
* Initialize Glean. This method should only be called once, subsequent calls will be no-op.
*
* # Note
*
* Before this method is called Glean will not be able to upload pings or record metrics,
* all such operations will be no-op.
*
* This is _not_ the way glean-core deals with this. It will record tasks performed before init
* and flush them on init. We have a bug to figure out how to do that for Glean.js, Bug 1687491.
*
* @param applicationId The application ID (will be sanitized during initialization).
* @param uploadEnabled Determines whether telemetry is enabled.
* If disabled, all persisted metrics, events and queued pings
Expand Down