Bug 1677445 - Implement PingType and ping maker #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
commented
Jan 11, 2021
brizental
force-pushed
the
1677445-ping-maker
branch
from
084b823 to
bfffc3c
Compare
brizental
commented
Jan 11, 2021
brizental
force-pushed
the
1677445-ping-maker
branch
from
bfffc3c to
29fc7be
Compare
Dexterp37
requested changes
Jan 12, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
This looks good overall. I have no major concern, but I'd like to take another look after the following changes are discussed/resolved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turned out to be bigger than I expected, there are many things interconnected. I tried to make it as lean as possible, but I can also break if off into two PRs, one for the pings database and another that relies on that for ping type and ping maker. Please let me know if you would like me to do that.
In Glean.js we can't just save pings in files, so I created the concept of a pings database, which is an abstraction over the underlying storage just like the metrics database.