Bug 1706024 - Fix path to ping entry point in package.json #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Argh, how did this fail CI? |
Dexterp37
previously approved these changes
Apr 19, 2021
Contributor
The specific fix seems reasonable. It might be a different problem. Holding back r+. |
Dexterp37
approved these changes
Apr 19, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
As discussed on Element the Ci failure seem to be unrelated.
Dexterp37
reviewed
Apr 19, 2021
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Contributor
Author
|
Merging in despite of the CI failure as it is unrelated and the fix in this PR is a real bug. CI failure is apparently related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how we didn't pick this up before, but ok.