Skip to content

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Sep 5, 2025

  1. Adds url, referrer, and title to the element_click event.
  2. Automatically captures these as part of recordElementClick().

Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1987158.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@caugner
Copy link
Contributor Author

caugner commented Sep 5, 2025

@travis79 Any tips how to test this? There don't seem to be tests for the page_load event, presumably because it's not straight-forward to mock?

@caugner caugner force-pushed the 1987158-capture-page-with-element-clicked branch from aee2bba to ec178a0 Compare September 5, 2025 15:13
@caugner caugner marked this pull request as ready for review September 5, 2025 15:28
@auto-assign auto-assign bot requested a review from badboy September 5, 2025 15:28
@badboy badboy removed their request for review September 8, 2025 11:53
@travis79 travis79 merged commit a7b7e1f into mozilla:main Sep 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants