Skip to content

Conversation

@jeddai
Copy link
Member

@jeddai jeddai commented Jul 16, 2025

There are no changes to functionality for clients, so there are similarly no changes to tests or documentation.

If we feel it would be imperative to add tests to cover these cases, please let me know!

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@jeddai jeddai changed the title Bug 1943952 - update uses of sessionStorage and localStorage in core … Bug 1943952 - update uses of sessionStorage and localStorage in core to be wrapped in a try/catch Jul 16, 2025
@jeddai jeddai force-pushed the add-try-catch-around-local-session-storage branch from d080b37 to 9c41da0 Compare July 16, 2025 13:55
@jeddai jeddai force-pushed the add-try-catch-around-local-session-storage branch from 9c41da0 to 5099a5d Compare July 16, 2025 15:05
@jeddai jeddai marked this pull request as ready for review July 16, 2025 15:11
@auto-assign auto-assign bot requested a review from badboy July 16, 2025 15:11
@jeddai jeddai self-assigned this Jul 16, 2025
Copy link
Member

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests is fine, the try/catch is explicitly very narrow around the calls that can throw.

@jeddai jeddai merged commit b13d2c2 into mozilla:main Jul 16, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants