Bug 1701578 - Remove the final circular dependencies! #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to remove the circular dependencies from the metric types in other commits.
This enables us to remove circular dependencies from the metric types files to the Glean.ts object.
This removes all our circular dependencies.
brizental
approved these changes
Apr 13, 2021
Contributor
brizental
left a comment
brizental
left a comment
There was a problem hiding this comment.
r+wc.
All my comments can be dealt with as follow ups, the only one I'd prefer to deal with before merging is the one about the dispatcher, I think it should not be a singleton by itself, but be in the Context. Unless I am missing something.
We should also file a bug for documenting this architecture and why the Context is important, and if we haven't yet a bug about removing the default export from Glean.ts and exporting it as something like export const DO_NOT_IMPORT_ME_UNLESS_YOU_KNOW_WHAT_YOU_ARE_DOING = Glean :D
Finally, did you check that this fixes the original bug about import order of Glean singleton and Metrics?
brizental
approved these changes
Apr 13, 2021
The check is currently broken due to some version incompatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @brizental , this introduces a new shared state object called
Contextand uses that in the metric types, instead of referring to the Glean object (creating circular dependencies).It additionally makes the
Dispatchera singleton.Finally, it enabled the circular dependencies checker on CI.